Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO]: Remove VERSION #3677

Open
polarathene opened this issue Nov 29, 2023 · 4 comments
Open

[TODO]: Remove VERSION #3677

polarathene opened this issue Nov 29, 2023 · 4 comments
Labels
kind/update Update an existing feature, configuration file or the documentation stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI
Milestone
v15.0.0

Comments

@polarathene
Copy link
Member

polarathene commented Nov 29, 2023 •
edited

Description

As per #3676

  • Remove the .gitattributes and .dockerignore references to VERSION.
  • Remove the /VERSION file itself.

This change is delayed until maintainers feel comfortable with dropping support for earlier releases update-check.sh compatibility (introduced in v10.0.0).
@polarathene polarathene added stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI kind/update Update an existing feature, configuration file or the documentation labels Nov 29, 2023
@polarathene polarathene added this to the v14.0.0 milestone Nov 29, 2023
@polarathene polarathene mentioned this issue Nov 29, 2023
Merged
6 tasks
@georglauterbach
Copy link
Member

I'd schedule this not before v15.0.0 is out.

@polarathene polarathene modified the milestones: v14.0.0, v15.0.0 Dec 5, 2023
@Zepmann
Copy link
Contributor

Zepmann commented Dec 18, 2023

Note that VERSION of release 13.0.1 contains:

13.0.0

For anyone thinking they need to rely on /VERSION inside a container when using bash (e.g. when using user-patches.sh): you don't. Read variable $DMS_RELEASE instead.

@georglauterbach

This comment was marked as resolved.

Sign in to view
@polarathene

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/update Update an existing feature, configuration file or the documentation stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI
Projects
None yet
Milestone
v15.0.0
Development

No branches or pull requests
3 participants
@Zepmann @polarathene @georglauterbach