pass namespace to kubectl build to fix incluster bug #2747
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Signed-off-by: Alexandre Garcia <alexandre.garcia@prodigygame.com> Co-authored-by: Noel Chin <noel.chin@prodigygame.com>
kuuji
force-pushed
the
fix/kubectl-incluster-namespace
branch
from
15d03a4
to
51a98e6
Compare
|
@kuuji Thanks for the PR! It's always great to see community contributions! I approved the e2e test run, so you should see some feedback through the GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2745
Please provide a short message that should be published in the DevSpace release notes
Fixes an issue where DevSpace, when ran
incluster, would deploy kubectl manifest files in the wrong namespace even when-nis provided on the command line.What else do we need to know?
I'm not setup to run the e2e for this yet but I did test the fix with kubectl (not yet with kustomize).
Since it's such a simple fix I figured I might as well open the PR to get some opinions while I do more testing.