[Bug] flags.warn_error_options.silence should be settable dbt_project.yml

[jtcohen6]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Missing silence here:

dbt-core/core/dbt/cli/flags.py

Lines 53 to 62 in 32a7f82

	def convert_config(config_name, config_value):
	"""Convert the values from config and original set_from_args to the correct type."""
	ret = config_value
	if config_name.lower() == "warn_error_options" and type(config_value) == dict:
	ret = WarnErrorOptions(
	include=config_value.get("include", []),
	exclude=config_value.get("exclude", []),
	valid_error_names=ALL_EVENT_NAMES,
	)
	return ret

Expected Behavior

def convert_config(config_name, config_value):
    """Convert the values from config and original set_from_args to the correct type."""
    ret = config_value
    if config_name.lower() == "warn_error_options" and type(config_value) == dict:
        ret = WarnErrorOptions(
            include=config_value.get("include", []),
            exclude=config_value.get("exclude", []),
            valid_error_names=ALL_EVENT_NAMES,
            silence=config_value.get("silence", []),  # this line is missing above
        )
    return ret

Steps To Reproduce

1. Create a project with a test in it

# dbt_project.yml
flags:
  warn_error_options:
    silence:
      - TestsConfigDeprecation

tests:  # has been renamed to data_tests
  +enabled: true

2. dbt parse -> still see the deprecation warning ("The tests config has been renamed to data_tests")
3. Apply the patch shown above -> dbt parse -> no deprecation warning

Relevant log output

No response

Environment

- Python: 3.10.11
- dbt: 1.8.0

Which database adapter are you using with dbt?

No response

Additional Context

No response

[kokorin]

I want to add some reasoning to this issue.
We checking if we can update to DBT 1.8, and we changed our configs from tests to data_tests.

The problem is that we use several DBT packages and those packages still use tests.
And I believe that DBT package developers will not update from tests to data_tests because they want to support compatibility with previous DBT versions.

May be it even makes sense to allow warning suppression based on package name, rather than suppressing globally for the whole project.

[jtcohen6]

@kokorin Appreciate that rationale! We have a separate issue for scoping that deprecation warning more narrowly:

• [Feature] [Spike+] scope the warning on tests directory to just the root package #9835

[ChenyuLInx]

https://github.com/dbt-labs/dbt-core/pull/10058/files#diff-9a7ad4b74c0941bce1368c1e8e12f0745bf0152b00f92df206375702b46e3a8eR133-R140
There should be an integration test catching this.
This might be because include is being required now.(something we potentially want to change).