Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUBRID] Add Ping Query to Keep Connection Alive #33184

Open
rathana-pvs opened this issue May 17, 2024 · 5 comments · May be fixed by #33394
Open

[CUBRID] Add Ping Query to Keep Connection Alive #33184

rathana-pvs opened this issue May 17, 2024 · 5 comments · May be fixed by #33394
Labels
external feature request x:cubrid

Comments

@rathana-pvs
Copy link
Contributor

rathana-pvs commented May 17, 2024 •
edited

Description

  • Add ping query to keep Cubrid connection alive.
@E1izabeth
Copy link
Member

We actually have this feature. You can turn it on here (set seconds to value other that 0)
image

@rathana-pvs
Copy link
Contributor Author

We actually have this feature. You can turn it on here (set seconds to value other that 0) image

This feature is to add a default test query when the isConnectionAlive(JDBCUtils.java:440) function is called.
I think this function was called when "Keep connection alive" set any value. Please correct me if I am wrong.

By default, "getTestSQL" was not set any value in the Generic plugin. So getTables "DBEAVERFAKETABLENAMEFORPING"
will be call instead (JDBCUtils.java:478). Cubrid supports "SELECT 1" as a test query, So We would like to add this as a default value for the test query.

@E1izabeth
Copy link
Member

Yes, got it. Thank you

@E1izabeth
Copy link
Member

@rathana-pvs do you plan to create a Pull Request?

@rathana-pvs
Copy link
Contributor Author

@rathana-pvs do you plan to create a Pull Request?

Yes, I do.
I will create Pull Request soon.

rathana-pvs added a commit to rathana-pvs/dbeaver that referenced this issue May 22, 2024
@rathana-pvs
dbeaver#33184 Add ping query to keep Cubrid connection alive.
0a8d1ff
@E1izabeth E1izabeth linked a pull request May 22, 2024 that will close this issue
#33184 Add ping query to keep Cubrid connection alive. #33394
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external feature request x:cubrid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#33184 Add ping query to keep Cubrid connection alive. rathana-pvs/dbeaver
2 participants
@E1izabeth @rathana-pvs