Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize Actions and Snapshots from the end #86

Open
dantaeusb opened this issue Dec 22, 2022 · 1 comment
Open

Synchronize Actions and Snapshots from the end #86

dantaeusb opened this issue Dec 22, 2022 · 1 comment
Assignees
Labels
critical Related to data corruption, should be fixed ASAP enhancement New feature or request

Comments

@dantaeusb
Copy link
Contributor

dantaeusb commented Dec 22, 2022

Currently, we sync actions and snapshots from the beginning of history lists, but if the player opened the painting screen recently and pressed undo. This might undo one of the first actions, theoretically leading to potential damage to the whole painting.

I think it is reasonable to sync from the end, plus, in that case, sync attribute introduced in 0.19.1 might not be actually needed, as we will have snapshot before the last action.

@dantaeusb dantaeusb self-assigned this Dec 22, 2022
@dantaeusb dantaeusb added enhancement New feature or request critical Related to data corruption, should be fixed ASAP labels Dec 22, 2022
@dantaeusb
Copy link
Contributor Author

This will require though to keep range of sync actions, thus increasing the complexity too. And we will have to prioritize new actions before first. It's not breaking, but probably one of the first things to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Related to data corruption, should be fixed ASAP enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant