Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CON-223] Cmd/Ctrl + Shift + Backspace doesn't stop streaming of diff #1012

Closed
3 tasks done
Tracked by #1009
sestinj opened this issue Mar 22, 2024 · 1 comment · May be fixed by #1027
Closed
3 tasks done
Tracked by #1009

[CON-223] Cmd/Ctrl + Shift + Backspace doesn't stop streaming of diff #1012

sestinj opened this issue Mar 22, 2024 · 1 comment · May be fixed by #1027
Labels
bug Something isn't working

Comments

@sestinj
Copy link
Contributor

sestinj commented Mar 22, 2024 •
edited

Before submitting your bug report

Relevant environment info

- OS:Mac
- Continue:0.9.91
- IDE:VS Code

Description

When the diff view is briefly going away it is because I am using the cmd+shift+backspace shortcut to cancel the generation, but after a second it comes back because streaming was not successfully cancelled.

bug-demonstration.mov

This is the function that gets called and is responsible for cancelling, so this is the starting point to debug.

To reproduce

  1. Highlight code
  2. Type '/edit fix this' or something similar
  3. when it starts generating, press cmd/ctrl+shift+backspace
  4. it will briefly go away but streaming continues and the diff view will return

Log output

No response

CON-223
@sestinj sestinj added the bug Something isn't working label Mar 22, 2024
@sestinj sestinj changed the title Cmd/Ctrl + Shift + Backspace doesn't stop streaming of diff [CON-223] Cmd/Ctrl + Shift + Backspace doesn't stop streaming of diff Mar 22, 2024
@sestinj sestinj mentioned this issue Mar 22, 2024
Open
13 tasks
@Iamshankhadeep Iamshankhadeep mentioned this issue Mar 26, 2024
Open
@justinmilner1
Copy link
Contributor

Continuing discussion from Discord:
I was concerned that _streamSlashCommand wasn't behaving correctly because the generating function ideStreamRequest wasn't yielding anything.
After looking into it further, this seems to be the intention - ideStreamRequest and up is intended for streaming into the chat, not the diff.
This is so parameters like 'recap' can be set to stream into the chat, without disrupting the diff.

@justinmilner1 justinmilner1 mentioned this issue May 10, 2024
Merged
@sestinj sestinj closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement the abort signal in /edit diff gen Iamshankhadeep/continue
2 participants
@sestinj @justinmilner1