Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvement opportunities #745

Open
Shane-Donlon opened this issue Feb 20, 2024 · 4 comments
Open

Accessibility improvement opportunities #745

Shane-Donlon opened this issue Feb 20, 2024 · 4 comments

Comments

@Shane-Donlon
Copy link
Contributor

Context

Please provide any relevant information about your setup:
Page Speed Insights results

Feedback:

  • Buttons do not have an accessible name
     
  • Background and foreground colors do not have a sufficient contrast ratio.
     

Screenshots

Google Lighthouse report error for poor contrast ratio in search bar
Google Lighthouse report error for button does not have an accessible name

Copy link

Hello @Shane-Donlon, thanks for opening your first issue! your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

@Maczi01
Copy link
Contributor

Maczi01 commented Feb 23, 2024

I think I can take it, but it require design changes. Should I focus only on contrast, ore something else? Or wait for storybook (a11y tests can be done there)

@NiallJoeMaher
Copy link
Contributor

@Maczi01 - I'm looking into this! I have some new designs. I also want to see how Storybook works with severside components. I know they recently started supporting this, and that's the way we are heading. The new designs will hopefully get rid of some of these issues.

Some of these things don't need to be fixed (like the CMD+K text) because it's just a placeholder and they can often fail here.

The button to scroll down definitely could use an accessible name, though, if you want to take that?

@Maczi01
Copy link
Contributor

Maczi01 commented Feb 23, 2024

Thanks for quick answer @NiallJoeMaher !

I heard they added support for RSC, but didn't try yet. No rush! If you need, I can try to help with it.

I can handle scroll issue, assign to me pls :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants