Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: fixed menu should hide when clicking publish #505

Open
xiaoniuniu89 opened this issue Oct 8, 2023 · 11 comments
Open

Editor: fixed menu should hide when clicking publish #505

xiaoniuniu89 opened this issue Oct 8, 2023 · 11 comments
Assignees

Comments

@xiaoniuniu89
Copy link
Contributor

Context

We have a fixed menu at the top of our new editor

Expected Behavior

when user clicks the publish button, the menu should not be visable

Current Behavior

visable from publish screen

Screenshots

Screenshot 2023-10-08 at 21 46 39

Steps to reproduce

Please provide detailed steps for reproducing the issue

go to alpha/create/new
click publish button

Additional info

@John-Paul-Larkin
Copy link
Member

Hey Niu. I will try this tomorrow.

@NiallJoeMaher
Copy link
Contributor

@Fishamble are you taking this one?

@VickTor61
Copy link

Hi @NiallJoeMaher . I will like to contribute to this or fix any other ticket that hasn't been resolved yet

@John-Paul-Larkin
Copy link
Member

Hi Vicktor. I am not working on this, so you can give it a try.

@vrun1208
Copy link
Contributor

Hi @NiallJoeMaher, looks like the issue is with css, its been a week there is no activity in this issue. If no one is working I can open a PR!

@NiallJoeMaher
Copy link
Contributor

@VickTor61 are you working on this or can I pass it over to @vrun1208?

@VickTor61
Copy link

@NiallJoeMaher currently working on it I should make a PR later today

@VickTor61
Copy link

@NiallJoeMaher The error doesn't show in development, Has it already been fixed?
Screenshot 2023-10-25 at 5 43 03 AM

@John-Paul-Larkin
Copy link
Member

Hi Vick. You are looking at the wrong editor.
http://localhost:3000/alpha/new is the url for the alpha editor.
app/alpha/new/[..postidarr]/client.tsx is the component.

@danboyce92
Copy link
Contributor

Hey there, I have a solution for this problem put together. Could I have this assigned to me so I can create a PR?

@vrun1208
Copy link
Contributor

vrun1208 commented Jan 2, 2024

I already fixed this issue earlier! @NiallJoeMaher can I open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants