Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include account and possibly other request details in TxMetadata #1597

Open
teq0 opened this issue Apr 1, 2023 · 2 comments
Open

Include account and possibly other request details in TxMetadata #1597

teq0 opened this issue Apr 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@teq0
Copy link

teq0 commented Apr 1, 2023

What would you like to be added or enhanced

Include additional attributes in TxMetadata to track the user/account that made the change, and, if possible, other info like the client IP address.

Why is this needed

For full auditability we need to not just be sure that records haven't been tampered with, we need to know how they were created i.e. by whom and from where. One simple case would be to be able to distinguish between updates made by "systems" versus updates made by humans (obviously there are credential management requirements also necessary for this to work). Having additional info like IP address could also help achieve this.

Additional context

#1575

@teq0 teq0 added the enhancement New feature or request label Apr 1, 2023
@jeroiraz
Copy link
Contributor

jeroiraz commented Apr 2, 2023

What would you like to be added or enhanced

Include additional attributes in TxMetadata to track the user/account that made the change, and, if possible, other info like the client IP address.

Why is this needed

For full auditability we need to not just be sure that records haven't been tampered with, we need to know how they were created i.e. by whom and from where. One simple case would be to be able to distinguish between updates made by "systems" versus updates made by humans (obviously there are credential management requirements also necessary for this to work). Having additional info like IP address could also help achieve this.

Additional context

#1575

Thanks for opening the feature request @teq0. It'd be great if you can help us investigating the best approach to obtain client IP address from the grpc connection

@teq0
Copy link
Author

teq0 commented Apr 2, 2023

Happy to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants