Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Solana Wallet OAuth #28

Open
Arunsoniiii opened this issue Apr 12, 2024 · 13 comments
Open

Adding a Solana Wallet OAuth #28

Arunsoniiii opened this issue Apr 12, 2024 · 13 comments

Comments

@Arunsoniiii
Copy link

We can have a wallet OAuth option for solana based wallets.

image

Hey @devsargam @hkirat can i work on that?

@devsargam
Copy link
Collaborator

@Arunsoniiii yep sure go on!!!

@Arunsoniiii
Copy link
Author

Thanks

@Arunsoniiii
Copy link
Author

Hey @devsargam where do we exactly need select wallet button in oAuth or can we have a saperate button ?

@devsargam
Copy link
Collaborator

Can do that but also can u make a fallback if someone doesn't have backpack acc still giving a solona address can let u claim the bounty. Make it urself no forced decision. Nice design + functional works

@Arunsoniiii
Copy link
Author

Arunsoniiii commented Apr 14, 2024

cool thingy,

Screencast.from.15-04-24.12_50_05.AM.IST.mp4

I made this, when we click on select wallet it'll automatically detect wallet and conncet to the wallet also if it handles all the problems, and suggestion: we can this in navbar.

please let me know how's it? @devsargam

@devsargam
Copy link
Collaborator

LGTM can u pr it?

@Arunsoniiii
Copy link
Author

Arunsoniiii commented Apr 14, 2024

wait sir video isn't good let me reshare @devsargam

Screencast.from.15-04-24.01_00_02.AM.IST.mp4

@devsargam
Copy link
Collaborator

Works but @Arunsoniiii keep in mind we don't want to confuse contributors (most of them don't know what the hell a wallet is). They should I ideally be able to put in their solona address and be gtg.

@Arunsoniiii
Copy link
Author

Arunsoniiii commented Apr 14, 2024

yeah you'r right but i think we can have saperate step where a contributor connect their wallet could be in navbar aur could be there, where they are claiming bounty @devsargam

@devsargam
Copy link
Collaborator

The logic is in contributors-web app

Also, migration of that solola to separate package could be a good thing

@Arunsoniiii
Copy link
Author

@devsargam I am facing access related error since past 2 days how can i fix this?

@devsargam
Copy link
Collaborator

@Arunsoniiii access as in? Can u try making ur github mail public and then try once?

@Arunsoniiii
Copy link
Author

Arunsoniiii commented Apr 16, 2024

@Arunsoniiii access as in? Can u try making ur github mail public and then try once?

Actully i'm getting error related to repo access so i thought I need ssh

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants