Fixed video bookmarking unexpected behaviour (most of the video are shown bookmarked by default) #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll videos as bookmarked
|
fixed already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
As you can see I haven't bookmarked any video but still it's shown as bookmarked.
And if I try to remove that bookmark, it gives this error.
It was too complicated to find the bug in the first go, but eventually I found that the course content fetching doesn't have any constraints that makes sure only currently logged-in user's bookmarks are being fetched.
So I've added that constraint, that resolved this issue.
I've make sure that the issue is resolved perfectly now.
Please go through this #635 (comment)
I've explained the issue & solution perfectly there.
Resolves #635
Checklist before requesting a review