Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerConf documentation should make clear that error_log and pid_file are only used in background #234

Open
palant opened this issue May 8, 2024 · 0 comments
Open

ServerConf documentation should make clear that error_log and pid_file are only used in background #234

palant opened this issue May 8, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@palant
Copy link

palant commented May 8, 2024

Describe the bug

I tried using error_log and pid_file settings in the config file which didn’t seem to have any effect. It took searching the codebase to realize that these settings are only used if the process is daemonized.

Pingora info

Pingora version: 0.1.1

Additional context

ServerConf documentation
@andrewhavck andrewhavck added the documentation Improvements or additions to documentation label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewhavck @palant