Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DNS Discover #222

Open
Benjmmi opened this issue Apr 29, 2024 · 1 comment
Open

Support DNS Discover #222

Benjmmi opened this issue Apr 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Benjmmi
Copy link

Benjmmi commented Apr 29, 2024

I noticed a TODO item in the code for DNS service discovery, and I've made some progress on it. It's still a work in progress. However, I'm also wondering if it's necessary to return the port based on the protocol
dns.rs

@eaufavor eaufavor added the enhancement New feature or request label May 1, 2024
@eaufavor
Copy link
Member

eaufavor commented May 1, 2024

Thanks for looking into this TODO.

There are many ways to do DNS based discovery. Beside using the A/AAAA record directly, which doesn't carry any information about ports, others use SRV and TXT DNS record which can carry port information.

Another thing is that our service discovery traits are public. You can use and share your implementation of DNS service discovery (as a "plugin") with 3rd party without contributing to our code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants