Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk cache #210

Open
lewisl9029 opened this issue Apr 18, 2024 · 0 comments
Open

Disk cache #210

lewisl9029 opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lewisl9029
Copy link

What is the problem your feature solves, or the need it fulfills?

Looks like pingora already provides a memory-cache module, but I suspect memory caching may be cost prohibitive for a lot of folks currently using something like NGINX, which caches to disk by default.

Describe the solution you'd like

Would be great to see a disk-cache module in addition to the memory-cache module!

Describe alternatives you've considered

We could always implement custom disk caching modules in user-land since pingora is so extensible, and the fact that the current memory-cache module is already abstracted behind a generic interface probably makes this even easier. But having off-the-shelf disk-caching would make it a lot easier to migrate existing NGINX-based workloads and help accelerate adoption.

Additional context

The fact that there's no disk-cache module in pingora makes me super curious about how Cloudflare handling caching with pingora today. Is all caching done in-memory (sounds expensive!)? Or maybe you have dedicated disk caching services living outside of the pingora proxies themselves? Would love to learn more. May be a good blog post topic? :)

@johnhurt johnhurt added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants