Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement page dirty marks. #1244

Closed
Centril opened this issue May 16, 2024 · 0 comments · Fixed by #1249
Closed

Implement page dirty marks. #1244

Centril opened this issue May 16, 2024 · 0 comments · Fixed by #1249
Assignees

Comments

@Centril
Copy link
Contributor

Centril commented May 16, 2024

Prerequisite for snapshotting.

Add a field unmodified_hash: Option<blake3::Hash> to PageHeader. Within this ticket, never set it to Some. It will likely need to be #[allow(unused)] or something until the full implementation of snapshotting reads it. Explicitly set it to None every time you write to the page.

With the full implementation of snapshotting, we will compute a hash and set the field to Some before dumping the page to a file. If the field is already Some, we will skip computing the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant