Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformulate #[test] fn bitblip() as a proptest to discover heisenbug in CI #1167

Closed
Centril opened this issue Apr 26, 2024 · 1 comment · Fixed by #1333
Closed

Reformulate #[test] fn bitblip() as a proptest to discover heisenbug in CI #1167

Centril opened this issue Apr 26, 2024 · 1 comment · Fixed by #1333
Assignees
@kim

Comments

@Centril
Copy link
Contributor

Centril commented Apr 26, 2024

We want to find the failing test case in https://github.com/clockworklabs/SpacetimeDB/actions/runs/8841180124/job/24277859858?pr=1107.
@Centril
Copy link
Contributor Author

Centril commented May 23, 2024

Happened again in https://github.com/clockworklabs/SpacetimeDB/actions/runs/9206183817/job/25323523524?pr=1285.

kim added a commit that referenced this issue Jun 4, 2024
@kim
commitlog: Make bitflip test a proptest
56742ff 
The test sometimes fails. As a proptest, we'll be able to seed it with
failing inputs.

Fixes: #1167
@kim kim mentioned this issue Jun 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 5, 2024
@kim
commitlog: Make bitflip test a proptest (#1333)
ff851ae 
* commitlog: Make bitflip test a proptest

The test sometimes fails. As a proptest, we'll be able to seed it with
failing inputs.

Fixes: #1167

* commitlog: Fix the bitflip test

Turns out we sometimes flipped a bit in the CRC32 itself, which makes
things go wrong in not the expected way.
@kim kim closed this as completed in #1333 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kim kim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

commitlog: Make bitflip test a proptest clockworklabs/SpacetimeDB
2 participants
@kim @Centril