Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Consider only storing TableId and recover table names in UX #1105

Open
Centril opened this issue Apr 17, 2024 · 0 comments
Open

Metrics: Consider only storing TableId and recover table names in UX #1105

Centril opened this issue Apr 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Centril
Copy link
Contributor

Centril commented Apr 17, 2024

Basically, the idea is that we go back to only storing TableIds in metrics and have the UX later translate the ids to table names, so that the BitCraft team also retain the information.

Relevant resources:

Possibly what we want is, as an example:

#[name = spacetime_table_names]
#[labels(table_id: u32, table_name: str)]
pub rdb_table_names: IntGaugeVec,

#[name = spacetime_num_table_rows]
#[labels(db: Address, table_id: u32)]
pub rdb_num_table_rows: IntGaugeVec,

and then e.g., the PromQL: spacetime_num_table_rows and on(table_id) spacetimedb_table_names should yield (db, table_id, table_name).

@Centril Centril added enhancement New feature or request performance labels Apr 17, 2024
@bfops bfops removed the performance label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants