Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BuiltinType in favor of variants directly in AlgebraicType #1104

Open
Centril opened this issue Apr 17, 2024 · 1 comment
Open

Remove BuiltinType in favor of variants directly in AlgebraicType #1104

Centril opened this issue Apr 17, 2024 · 1 comment
Labels
abi-break A PR that makes an ABI breaking change release-1.0

Comments

@Centril
Copy link
Contributor

Centril commented Apr 17, 2024

In other words, move all variants from BuiltinType to AlgebraicType and remove the former enum.
This should make AlgebraicType smaller, hopefully.

Affects the BSATN encoding of AT so this is a breaking ABI change.
@Centril Centril added abi-break A PR that makes an ABI breaking change release-1.0 labels Apr 17, 2024
@Centril
Copy link
Contributor Author

Centril commented Apr 17, 2024

SpacetimeDB part of this is #379.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abi-break A PR that makes an ABI breaking change release-1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Centril