-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posted store is set to true even when data is invalid #407
Comments
The intent of posted is to be true as soon as the form has been posted. |
I'm not sure I understand your response. The way it has always worked is that unless the form is posted to the server, posted is not set to true. This change completely breaks the functionality that I have been depending on and has been that way since I started using the library in 1.x. If the data is not posted to the server because of errors, then it is not posted, correct? |
You expect too much, it's an open source project. Please contribute some falling tests if you've found a regression. |
For what it's worth this is currently my favourite library, and I really appreciate all the work and effort that is going in it, and to maintain it. It seems like you think I am being unreasonable. I am reporting what I believe is a bug. I am willing to conceded that the behaviour I am depending on is not specifically intended in SPA mode. I have spent a lot of time investigating every bug I encounter in order to make sure it is a bug, even tracking down the exact version change that it happened in. And testing things out in the REPLs (which are often quite buggy) to make sure it's not something weird going on in my machine. I'd be happy to contribute if it helps improve the library, although my time is quite limited at the moment. |
You seem to expect no regressions and that the documentation and changelog should be fully updated, which is unrealistic for an open source project with a single maintainer and a few very kind sponsors. You say your time is quite limited, well, it's the same for others. But that's how it is with OSS, you pay with your time. superForm and superValidate are the two functions that should be used for testing the posted store, here they are: https://github.com/ciscoheat/sveltekit-superforms/tree/main/src/tests |
Description
The posted store returned from the
superForm
function is set to true whenever the form is submitted, even when it fails to submit with a success result.This worked up until version 2.7.0, and seems to have broken in 2.8.0.
MRE
The text was updated successfully, but these errors were encountered: