Create new PATCH partner endpoint #418
Labels
complexity: moderate
Time needed to do this ticket will be moderate e.g. 1-2 days
help wanted
Extra attention is needed
maintenance
Maintenance / chore work
Milestone
Overview
We want to at some point be using Rest properly. Currently, this is not the case. Each endpoint which deviates from REST patterns should be duplicated and corrected. We can later migrate the frontend over to the correct endpoint and delete the incorrect usage. We don't need to be super strict but just better than where we are now.
Our current url POST
/v1/partner/delete
does not make sense. Firstly, this is because functionally it is a soft delete. We merely set the status of the partner from active to inactive. Secondly the usage of POST is incorrect.Action Items
/v1/partner/delete
endpoint. We want to replicate the functionality of this endpoint./v1/partner/:id
and with a body that accepts{active: boolean}
.deletePartner
, it should beupdatePartner
.updatePartner
should take both the partnerId and a body DTO which all the changes inside. Please see bloom-backend/src/partner-feature/partner-feature.service.ts. Look atupdatePartnerFeature
as an example.Resources/Instructions
The text was updated successfully, but these errors were encountered: