Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression-eval@5.0.1: The expression-eval npm package is no longer maintained #459

Open
giovanni-bertoncelli opened this issue Oct 5, 2023 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@giovanni-bertoncelli
Copy link

I get this error while installing casbin:

npm WARN deprecated expression-eval@5.0.1: The expression-eval npm package is no longer maintained. The package was originally published as part of a now-completed personal project, and I do not have incentives to continue maintenance.

I think that dependency should be upgraded.

@casbin-bot
Copy link
Member

@nodece @Shivansh-yadav13

@casbin-bot casbin-bot added the question Further information is requested label Oct 5, 2023
@giovanni-bertoncelli
Copy link
Author

Any thoughts on this? @nodece @hsluoyz
We have production code running on this

@nodece
Copy link
Member

nodece commented Nov 21, 2023

It is sad news that the expression-eval is no longer maintained, but we already used this library for a long time, and it is stable and safe(no CVE), so don't worry about this library.

@hsluoyz Should we fork the express-eval repo and publish our version?

If you hear anything, please let us know!

@hsluoyz
Copy link
Member

hsluoyz commented Nov 21, 2023

Forking expression-eval is the last resort. Because we don't have that many developers to focus on maintaining it at the same time. What about switching to: https://github.com/silentmatt/expr-eval ?

@nodece
Copy link
Member

nodece commented Nov 21, 2023

The node-casbin depends on the async compile from expression-eval, could you switch to expre-eval, and try to test the async compile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Development

No branches or pull requests

4 participants