refactor: converted index.js to index.ts for OverflowMenu
#16494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue: #16154
Closes #16444
Closes #16447 as part of exporting props for
Overflowmenu
Changed from Index.js to Index.tsx as part of typescript adoption.
Changelog
New
Changed
OverflowMenuComponent
astypeof React.Component
for type assertionrenderIcon
's type asComponentType<IconProps>
Offset
interface to acceptnull
andundefined
matchingPropType
assertionIconProps
type as part ofrenderIcon
's assertionaria-label
as option in the main interfaceOverflowMenuProps
Testing / Reviewing