Missing terms and condition text/link on scheduling link

[dahal]

Found a bug? Please fill out the sections below. 👍

Issue Summary

I just noticed a bug while I was embedding cal link, looks like its also on regular scheduling page

Steps to Reproduce

1. Go to any scheduling link, you will see "Terms" / "Terms of service" missing

[dosubot]

It looks like the issue with the missing "Terms and Conditions" link on the scheduling page might be related to the conditional rendering logic in the application's code. Specifically, the application checks for certain conditions to be met before displaying the "Terms and Conditions" link. These conditions involve the isPlatform flag and the IS_CALCOM constant.

1. isPlatform Flag: This flag is used to determine if the application is being used within another platform. If a clientId is present, indicating the user is considered a platform user, the isPlatform flag is set to true, which might prevent the "Terms and Conditions" link from being displayed.

2. IS_CALCOM Constant: The application also checks if it's running on Cal.com's platform through the IS_CALCOM constant. If for some reason IS_CALCOM is set to false, the "Terms and Conditions" link will not be rendered.

3. WEBSITE_URL Constant: The links to "Terms" and "Privacy Policy" are constructed using the WEBSITE_URL constant. If you're running this in a local development environment or if the environment variable NEXT_PUBLIC_WEBSITE_URL is set incorrectly, it could affect the rendering of these links.

To troubleshoot this issue, you might want to:

• Verify the conditions under which the isPlatform flag is set to true in your environment.
• Check the configuration or the codebase for how the IS_CALCOM constant is determined and ensure it's set correctly for your use case.
• Ensure the NEXT_PUBLIC_WEBSITE_URL environment variable is set correctly, especially if you're working in a local development environment.

These steps should help in diagnosing why the "Terms and Conditions" link is not appearing as expected.

Details

Sources

• [CAL-1101] Terms & Conditions Check Box
• packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
• apps/web/pages/settings/platform/index.tsx
• packages/platform/atoms/hooks/useIsPlatform.ts
• apps/web/pages/signup.tsx
• packages/lib/constants.ts
• apps/web/pages/settings/platform/oauth-clients/create.tsx

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

[deepak-singh19]

hey @ciaranha I have created a PR for the issue and let me know if anything needs to be change. This is how it looks now.