Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Enable ShouldAlwaysRunBraveAdsService and ShouldAlwaysTriggerBraveSearchResultAdEvents features by default #23743

Merged
merged 1 commit into from
May 20, 2024

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 18, 2024

Resolves brave/brave-browser#38408

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm features are enabled by default at brave://flags (Desktop/Android)

@tmancey tmancey self-assigned this May 18, 2024
@tmancey tmancey requested a review from a team as a code owner May 18, 2024 15:45
@bsclifton
Copy link
Member

Doing an admin merge - the failing tests are not related to this

@bsclifton bsclifton merged commit 15e40ae into master May 20, 2024
18 of 19 checks passed
@bsclifton bsclifton deleted the issues/38408 branch May 20, 2024 21:31
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants