Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EVM ABI decoder to support dynamic and tested types #38402

Open
onyb opened this issue May 17, 2024 · 0 comments · May be fixed by brave/brave-core#23730
Open

Extend EVM ABI decoder to support dynamic and tested types #38402

onyb opened this issue May 17, 2024 · 0 comments · May be fixed by brave/brave-core#23730
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes release-notes/exclude

Comments

@onyb
Copy link
Member

onyb commented May 17, 2024

The current ABI decoder does not support complex composite types and dynamic types. Implementing this will allow us to decode arbitrary calldata and also avoid dependency on LiFi API to parse calldata of bridge transactions.

Note to QA: Ensure that transaction signing screen for common use-cases still work as expected (no need to approve though), and Safe Sign screen continues to work for 0x swaps.

@onyb onyb added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 17, 2024
@onyb onyb self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes release-notes/exclude
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant