Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand BytecodeTest.methodExists to detect change of method modifier #38401

Closed
AlexeyBarabash opened this issue May 17, 2024 · 0 comments · Fixed by brave/brave-core#23699
Closed
Assignees
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

The changes in upstream like
https://source.chromium.org/chromium/chromium/src/+/618819a4be308d02459fb6b06df5a00515b5ee26
which caused HomepageManager.shouldCloseAppWithZeroTabs become non-static - are not detected by our BytecodeTest . But this needs an update of patching, because otherwise the crash will happen, as example:

05-11 07:57:49.875  9753  9753 E AndroidRuntime: FATAL EXCEPTION: main
05-11 07:57:49.875  9753  9753 E AndroidRuntime: Process: org.chromium.android_browsertests_apk:test_process, PID: 9753
05-11 07:57:49.875  9753  9753 E AndroidRuntime: java.lang.VerifyError: Verifier rejected class org.chromium.chrome.browser.multiwindow.MultiWindowUtils: boolean org.chromium.chrome.browser.multiwindow.MultiWindowUtils.hasAtMostOneTabWithHomepageEnabled(org.chromium.chrome.browser.tabmodel.TabModelSelector) failed to verify: 
boolean org.chromium.chrome.browser.multiwindow.MultiWindowUtils.hasAtMostOneTabWithHomepageEnabled(org.chromium.chrome.browser.tabmodel.TabModelSelector): 
[0xF] 'this' argument 'Reference: org.chromium.chrome.browser.homepage.HomepageManager' not instance of 
'Reference: org.chromium.chrome.browser.homepage.BraveHomepageManager' 
(declaration of 'org.chromium.chrome.browser.multiwindow.MultiWindowUtils' appears in 
/data/app/~~XpvqnEAgrvdvUZjKOVXV1Q==/org.chromium.android_browsertests_apk-VTozqjmUedcNagsBiurH3w==/base.apk!classes5.dex)
05-11 07:57:49.875  9753  9753 E AndroidRuntime:        at org.chromium.chrome.browser.multiwindow.MultiWindowUtils.isMultiInstanceApi31Enabled(MultiWindowUtils.java:156)
05-11 07:57:49.875  9753  9753 E AndroidRuntime:        at org.chromium.chrome.browser.multiwindow.MultiInstanceManager.create(MultiInstanceManager.java:127)
05-11 07:57:49.875  9753  9753 E AndroidRuntime:        at org.chromium.chrome.browser.ChromeTabbedActivity.onPreCreate(ChromeTabbedActivity.java:560)
05-11 07:57:49.875  9753  9753 E AndroidRuntime:        at org.chromium.chrome.browser.init.AsyncInitializationActivity.onCreate(AsyncInitializationActivity.java:309)

Need to implement detection of modifier change at BytecodeTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants