Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing account derivation shows error for Solana Hardware wallet import #38400

Closed
srirambv opened this issue May 17, 2024 · 1 comment · Fixed by brave/brave-core#23789
Closed

Changing account derivation shows error for Solana Hardware wallet import #38400

srirambv opened this issue May 17, 2024 · 1 comment · Fixed by brave/brave-core#23789
Assignees
@josheleonard
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/Yes regression release-notes/exclude
Milestone
1.67.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Changing account derivation shows error for Solana Hardware wallet import

Steps to Reproduce

  1. Connect Ledger/Trezor
  2. Open Import Hardware wallet
  3. Select Solana
  4. Change derivation method
  5. Shows error

Actual result:

Hardware.Wallet.Solana.Error.mp4

Expected result:

Should be able to select different derivation path

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @josheleonard
@srirambv srirambv mentioned this issue May 17, 2024
Closed
@josheleonard josheleonard mentioned this issue May 22, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 6, 2024
@brave-builds brave-builds mentioned this issue Jun 6, 2024
Merged
7 tasks
@LaurenWags
Copy link
Member

Requires 1.67.110 or higher to test 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/Yes regression release-notes/exclude
Projects
Web3
Status: Done
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): allow switching derivation paths during SOL import brave/brave-core
4 participants
@srirambv @LaurenWags @josheleonard @brave-builds