Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send an internal data to UI. #23732

Merged
merged 1 commit into from
May 19, 2024
Merged

Don't send an internal data to UI. #23732

merged 1 commit into from
May 19, 2024

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented May 17, 2024

Resolves brave/brave-browser#38386

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp self-assigned this May 17, 2024
@boocmp boocmp requested a review from a team as a code owner May 17, 2024 12:57
@boocmp boocmp requested a review from darkdh May 17, 2024 14:11
@boocmp boocmp merged commit 9c75c9d into master May 19, 2024
20 checks passed
@boocmp boocmp deleted the tor_pt_settings branch May 19, 2024 02:47
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants