Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Apply changes button is shown in the Tor Use Bridges setting #38386

Closed
MadhaviSeelam opened this issue May 16, 2024 · 3 comments · Fixed by brave/brave-core#23732
Closed

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 16, 2024

Description

Found while testing #37896. In the Tor windows section of brave://settings/privacy page, unnecessary Apply changes button is shown. When clicked, doesn't do anything and it just disappears and when refreshed the page, it reappears. This button wasn't displayed in 1.65.x

Steps to Reproduce

  1. Install 1.67.85
  2. launch Brave
  3. open brave://settings/privacy
  4. navigate to Tor windows section

Actual result:

Apply changes button is shown. When clicked doesn't do anything. Refreshed the page and the button reappears

image

Expected result:

image

Reproduces how often:

Easily

Brave version (brave://version info)

Version/Channel Information:

Brave | 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
-- | --
Revision | d01060f5ec155e6eb64a335203663a29c0e5d81f
OS | Windows 11 Version 23H2 (Build 22631.3593)
  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @boocmp

@MadhaviSeelam MadhaviSeelam added this to Untriaged in Tor and Private Windows via automation May 16, 2024
@MadhaviSeelam MadhaviSeelam changed the title Redundant Apply changes button is shown in the Tor Use Bridges setting in the Redundant Apply changes button is shown in the Tor Use Bridges setting May 16, 2024
@stephendonner
Copy link

I see it too with

Brave | 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (x86_64)
-- | --
Revision | d01060f5ec155e6eb64a335203663a29c0e5d81f
OS | macOS Version 11.7.10 (Build 20G1427)
Screen Shot 2024-05-16 at 1 43 20 PM

@rebron
Copy link
Collaborator

rebron commented May 16, 2024

cc: @fallaciousreasoning @boocmp Wondering if the Nala updates aren't sticking here either?

@fallaciousreasoning
Copy link

It doesn't repro in 1.66, which is where the Nala changes landed, so it might not be - I'll dig in a bit but it might be related to upstream moving to Lit from Polymer

Tor and Private Windows automation moved this from Untriaged to Completed May 19, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 19, 2024
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants