-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for highlight customization #66
Comments
Hello there! I'm glad you opened this issue, because this is something I've been thinking about adding for a long time. I agree that giving the user the option to override the colors is useful. Perhaps the default colors can be improved upon as well. Would you mind letting me know what color scheme you're using? Since circumflex uses a lot of colors, it's been somewhat challenging finding good foreground and background colors to compliment them well. |
Hey, glad you found this interesting. I use a personal base16 colorscheme which may be very biased against some colors and particularly bad for people depending on colors for readability but at least for me is very aesthetically pleasing, but that's up to the individual I suppose. I think implementing base16 scheming is the most complete approach for making the application themable, both from available colorschemes perspective as well as allowing for easy customized colors. You can essentially produce almost any color configuration out of your base16 basic colors via mustache templates which allows for unified theming across multiple applications which is neat. It would be a good place to start would be making your colors adhere to the standards which by itself will fix the colors for people having their terminal basic colors configured out of the box. Then once you got that in place its very easy even offering the ability for users to chose from a set of base16 themes effectively implementing theming in your application. Hope this helps! |
Thanks again for the feedback. I decided to move away from custom colors altogether, and now I am only using colors from within the first 16 set by the users color scheme. I hope this will make I can still add options for overriding the theme to change the highlighting for the different elements, but this might require some larger changes first. |
Thank you for the kind words and for the suggestions 🙏 I think that allowing the colors to be customized is great for use cases like you bring up. Then the user can customize the highlighting in any part of the application. I'll keep this ticket open until we support this feature. |
Greetings, that's such an incredible interface you managed to pull together there, congratz!
The only otherwise minor issue my experience are the background colors on the header and footer row which stand out in a distracting way and when coupled with a hardcoded background color and make the UX much less pleasing, at least for me.
There are few approaches that came to mind as a proposed fix, its up to you if and which one you deem most suitable.
The nature of the issue is considered minor by many and deciding to omit such a feature is totally understandable.
1 - Add flag(s) for disregarding background color of the fist and last row. The simplest option as far as I'm concerned.
2 - Add an option for using the default 16 colors already in use. This is the best option for properly integrating any kind of theme via the base16 framework.
3 - Expose an option/flag for setting internal colors eg akin to fzf.
Eg:
--color 'fg:#bbccdd,fg+:#ddeeff,bg:#334455,preview-bg:#223344,border:#778899'
Let me know your thoughts, thanks!
The text was updated successfully, but these errors were encountered: