Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EKS CloudFormation node pool template from using NodeAutoScalingInitSize to NodeAutoScalingGroupDesiredCapacity #3309

Open
pregnor opened this issue Nov 13, 2020 · 0 comments
Labels
area/node-pool Kubernetes cluster node pools cloud/aws distribution/eks Amazon EKS DX Developer Experience kind/tech-debt

Comments

@pregnor
Copy link
Member

pregnor commented Nov 13, 2020

Is your feature request related to a problem? Please describe.

Currently we are using NodeAutoScalingInitSize parameter in EKS node pool stack CloudFormation templates as the desired size of the node pool due to historical reasons.

The EKS CloudFormation node pool template officially introduced the NodeAutoScalingGroupDesiredCapacity parameter to implement the same (or rather more generalized) usage for the stack template.

It would eliminate the tech debt of this difference if we could migrate the template to use the new parameter and deprecate the old one.

Note: the solution must be ready to handle reading (listing, retrieving old values) and writing (updating) older (pre-parameter, 1.0.0) templated stacks using the newer template during stack update, and especially must be careful about handling UsePreviousValue scenarios on stacks created from template not containing a newly introduced parameter.

Describe the solution you'd like to see

Describe alternatives you've considered

Additional context

Template versioning is reliable for migration/workaround purposes. Empty/missing/1.0.0 version is lacking NodeAutoScalingGroupDesiredCapacity while from 2.0.0 onward, the template contains this parameter.

@pregnor pregnor added cloud/aws distribution/eks Amazon EKS DX Developer Experience kind/tech-debt area/node-pool Kubernetes cluster node pools labels Nov 13, 2020
@pregnor pregnor changed the title Migrate EKS CloudFormation node pool template from using NodeAutoScalingInitSize to NodeAutoScalingDesiredCapacity Migrate EKS CloudFormation node pool template from using NodeAutoScalingInitSize to NodeAutoScalingGroupDesiredCapacity Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/node-pool Kubernetes cluster node pools cloud/aws distribution/eks Amazon EKS DX Developer Experience kind/tech-debt
Projects
None yet
Development

No branches or pull requests

1 participant