Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise EKS node pool surge node logic now that NASGMinInstancesInService is available in CF templates #3299

Open
pregnor opened this issue Nov 9, 2020 · 0 comments
Labels

Comments

@pregnor
Copy link
Member

pregnor commented Nov 9, 2020

Is your feature request related to a problem? Please describe.

The EKS node pool update surge node handling logic was implemented using NASGMaxSize and NASGMaxBatchSize values only.

Describe the solution you'd like to see

We should double check the custom logic whether the newly available NASGMinInstancesInService attribute can help us replacing parts or the whole of the EKS node pool update surge node implementation logic using the built-in features of the CloudFormation template and its backing services.

Describe alternatives you've considered

If the supported max batch size and min instances in services cannot replace the custom surge logic, we can keep the current logic intact.

Additional context

AWS CloudFormation template UpdatePolicy attribute

@pregnor pregnor added cloud/aws distribution/eks Amazon EKS kind/tech-debt area/node-pool Kubernetes cluster node pools labels Nov 9, 2020
@pregnor pregnor changed the title Revise EKS node pool surge node logic now that NASGMinInstancesInService is available Revise EKS node pool surge node logic now that NASGMinInstancesInService is available in CF templates Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant