Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename all parameters to use snake_case everywhere. #387

Open
azjezz opened this issue Dec 22, 2022 · 3 comments
Open

rename all parameters to use snake_case everywhere. #387

azjezz opened this issue Dec 22, 2022 · 3 comments
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@azjezz
Copy link
Owner

azjezz commented Dec 22, 2022

currently, functions use $snake_case for parameters, and methods use $camelCase, IMO, parameters should be $snake_case everywhere.

e.g:

$semaphore = new Async\Semaphore(concurrency_limit: $a, operation: $b);

instead of

$semaphore = new Async\Semaphore(concurrencyLimit: $a, operation: $b);
@azjezz azjezz added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 22, 2022
@azjezz azjezz added this to the 3.0.0 milestone Dec 22, 2022
@azjezz azjezz self-assigned this Dec 22, 2022
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: BC Break A change that will result in a backward compatibility break in the public API. labels Dec 22, 2022
@azjezz azjezz removed their assignment Dec 22, 2022
@azjezz
Copy link
Owner Author

azjezz commented Dec 22, 2022

cc @veewee WDYT?

@veewee
Copy link
Collaborator

veewee commented Dec 22, 2022

Sounds good: I'm all in on consistancy!
I assume there will be a cs rule enforcing and fixing this for us somewhere.

@githubjeka
Copy link

What is the reason not to do like in psr-12 ?

@veewee veewee removed this from the 2.4.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

No branches or pull requests

3 participants