fix: ignored platform property on bundling an asset with docker #30240
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
t3r
changed the title
|
The PR Linter complains about missing changes to test/integration test files. There is currently no existing test in |
t3r
force-pushed
the
t3r/fix-bucketdeployment-platform
branch
from
5ee7736
to
10acb57
Compare
…th docker Fixes aws#30239 The bundling-properties value was not copied from the AssetBundling properties to the image.run properties so the --platform option for docker run was never added. This patch copies the platform property for AssetBundlingBindMount and AssetBundlingVolumeCopy. This fix makes the 'platform' property work as described in https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.BundlingOptions.html#platform - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
t3r
force-pushed
the
t3r/fix-bucketdeployment-platform
branch
from
10acb57
to
d2f29bc
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This fix makes the 'platform' property work as described in https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.BundlingOptions.html#platform
The bundling-properties value was not copied from the AssetBundling properties to the image.run properties so the --platform option for docker run was never added. This patch copies the platform property for AssetBundlingBindMount and AssetBundlingVolumeCopy.
fixes #30239
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license