-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition disappear for Idefics activation #477
Comments
Hi, anyone could check this issue ? |
Hello |
Hi @KietNgoTuan I've changed a little bit the code to handle this issue. That change need to add a configuration in bin/config.json file like this : You have to set explicitly your default Security Group. "vpc": {
"vpcId": "vpc-xxxxx",
"createVpcEndpoints": false,
**"vpcDefaultSecurityGroup": "sg-xxxxx"**
}, ++ |
I've just opened a PR : #498 |
Hi,
since release version 4.0.3 it seems there is condition disappeared for Idefics Interface activation or not.
You can compare this latest version with previous one like v4.0.3 at the same line :
aws-genai-llm-chatbot/lib/aws-genai-llm-chatbot-stack.ts
Line 110 in 3c710bf
is it normal or a mistake ? In my case I cannot not deploy anymore due this new resource not available before and it need a default security group ID for private VPC endpoint.
This happened when VPC already exist, it seems the method "ec2.Vpc.fromLookup" does not detect a default security group.
Here the impact :
https://github.com/aws-samples/aws-genai-llm-chatbot/blob/main/lib/model-interfaces/idefics/index.ts#L41
This property "props.shared.vpc.vpcDefaultSecurityGroup" should contains a default security group ID.
For an existing VPC this value seems to be blank.
This condition impact also ResourcePath for NagSuppressions.
Best regards,
The text was updated successfully, but these errors were encountered: