-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy 2 compat: tests failing with default print options #16423
Comments
note for later: I think one of the failures we got in |
Maybe an idea is to merge #15065 for main, and then backport pieces of that? In any case, it seems sensible for me to rebase that... |
Actually what I'm finding out thusfar is that the failures I'm pointing to in this issue are not resolved by #15065, and require their own solution. Since they are related but separable problems, I don't think we need to discuss this here. |
This comment was marked as resolved.
This comment was marked as resolved.
@neutrinoceros - in rebasing #15065, I found test failures with pandas which are not representation-related. Are those among those you are thinking of? Also, if |
Re: #16423 (comment) Nevermind, I just saw #15095 (comment) |
re #16423 (comment): |
I actually wondered about whether we shouldn't just merge #15065 for main, and then backport the commits that do not have to do with the documentation (i.e., docs for 6.1 stay at numpy < 2.0 format). Though perhaps effectively that is the same amount of work... |
I think it's very much a comparable effort and not a big undertaking for us two, but the cherry-picking approach should make reviewing easier. If you agree to it, it shouldn't take me long to finish cherry picking the user-facing parts (only two more PRs). |
OK, let's go that route - then #15065 will probably get in when numpy 2.0 is out (just saw rc2 was released). |
numpy 2.0 has a release date: numpy/numpy#24300 (comment) I'd recommend merging the remaining PRs related to this issue and cutting a 6.1.1 release before june 16th |
Yes ! |
When they are all in, do we need a follow-up issue to get rid of |
I don't expect it to get in the way of anyone so it should be very low priority, but I do have a personal reminder to clean it up when the time comes. update: #16491 |
Well, I can't arrest you or anything... 😸 Thanks for opening the issue! It is good to have it out in the open to show people we're aware of it. |
Let's call it making me an offer I can't refuse 🤌🏻 |
Alright, everything was merged, let's close this ! thanks ! |
We currently have about 400 tests that don't pass against numpy 2.0 if we remove the following line
astropy/astropy/conftest.py
Line 28 in b2e38be
90% of the solution is already isolated in #16416, and we can probably extract backportable solutions for the other 10% from #15065.
I'm seeing ~400 failures (doctests included) on main, 90% of which are resolved by #16416, but not all of what's left are doctests, which, as discussed in #15095, are not critical and can be post-poned to after numpy 2.0.0 final comes out (supposedly this would be for astropy 7.0.0)
Everything that's not a doctest, and not already fixed in #16416, should probably be addressed for 6.1.1
Affected modules:
coordinates
(1 test) TST: adapt a coordinates test to numpy 2 #16427io.fits
(4 tests) BUG: fix compatibility with numpy 2 in diff reports (io.fits, utils) #16426io.votable
(15 tests) BUG: fix bugs in io.votable related to numpy 2's representation of scalars #16442table
(7 tests) TST: adapt table representation tests to numpy 2 #16433utils
(2 tests) BUG: fix compatibility with numpy 2 in diff reports (io.fits, utils) #16426 and BUG: fix bugs with how masked structured arrays were represented with numpy 2 #16443I expect solutions were already found by @mhvk in #15065, so it's mostly a matter of making targeted cherry-picks.
The text was updated successfully, but these errors were encountered: