Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken redirect to archived workflows #13056

Open
2 of 4 tasks
apiwoni opened this issue May 16, 2024 · 0 comments
Open
2 of 4 tasks

Broken redirect to archived workflows #13056

apiwoni opened this issue May 16, 2024 · 0 comments
Labels
area/ui type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@apiwoni
Copy link

apiwoni commented May 16, 2024

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

The following URL https://{{serverUrl}}/workflows/{namespace}/{workflowName} no longer redirects to https://{{serverUrl}}/archived-workflows/{namespace}/{metadata.uid} starting with v3.4.14 when fix(ui): missing uiUrl in ArchivedWorkflowsList #12172 has been committed.

Pasting https://{{serverUrl}}/archived-workflows/{namespace}/{metadata.uid} directly in the browser works as expected.

Argo UI shows the following:

Error: Failed to execute 'pushState' on 'History': A history state object with URL 'https://archived-workflows/{{namepsace}}/87e895f1-50df-443b-971d-218beae9d25f' cannot be created in a document with origin 'https://xxx' and URL 'https://xxx/archived-workflows?namespace={namespace}&name=workflowName&deep=true'.
    at https://xxx/main.fa82dae05c4e68e1ec09.js:446:1047769
    at Object.confirmTransitionTo (https://xxx/main.fa82dae05c4e68e1ec09.js:446:1045618)
    at Object.push (https://xxx/main.fa82dae05c4e68e1ec09.js:446:1047680)
    at t.componentDidUpdate (https://xxx/main.fa82dae05c4e68e1ec09.js:433:843312)
    at is (https://xxx/main.fa82dae05c4e68e1ec09.js:398:83471)
    at hc (https://xxx/main.fa82dae05c4e68e1ec09.js:398:101246)
    at t.unstable_runWithPriority (https://xxx/main.fa82dae05c4e68e1ec09.js:406:3844)
    at Ho (https://xxx/main.fa82dae05c4e68e1ec09.js:398:45024)
    at pc (https://xxx/main.fa82dae05c4e68e1ec09.js:398:97718)
    at Qs (https://xxx/main.fa82dae05c4e68e1ec09.js:398:93872)

componentDidUpdate has added uiUrl in v3.4.14 per https://github.com/argoproj/argo-workflows/pull/12172/files

Version

v3.4.16

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A
@agilgur5 agilgur5 added the type/regression Regression from previous behavior (a specific type of bug) label May 16, 2024
@agilgur5 agilgur5 added this to the v3.4.x patches milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

No branches or pull requests

3 participants