Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Batches are not prepended correctly when CTRL+C #648

Open
gabrielmbmb opened this issue May 18, 2024 · 0 comments
Open

[BUG] Batches are not prepended correctly when CTRL+C #648

gabrielmbmb opened this issue May 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gabrielmbmb
Copy link
Member

Describe the bug
When stopping a pipeline with CTRL+C, the batches from the step input queues are prepended back to the _BatchManager so no information is lost.

The _BatchManagerStep contains a data dictionary with batches from the predecessors steps, but when we're reingesting the batches from the input queue of a certain step, the batch.step_name is now equal to the step (not the predecessor step). This causes a KeyError exception.

Expected behaviour
The batch is added correctly back to the _BatchManagerStep and it can be used in the next pipeline execution if use_cache=True.

@gabrielmbmb gabrielmbmb added the bug Something isn't working label May 18, 2024
@gabrielmbmb gabrielmbmb self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant