Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATION] Remove messages support via instruction in TextGeneration #644

Closed
alvarobartt opened this issue May 17, 2024 · 0 comments · Fixed by #676
Closed

[DEPRECATION] Remove messages support via instruction in TextGeneration #644

alvarobartt opened this issue May 17, 2024 · 0 comments · Fixed by #676
Assignees
Milestone

Comments

@alvarobartt
Copy link
Member

Description

In distilabel v1.0.0 we included the task TextGeneration and at the last moment we decided to include support for an already formatted chat like object i.e. a list of dicts with the keys role and content; but that's counter intuitive since to use TextGeneration with say the column messages one would need to always provide the input_mappings and the logic of format_input had some conditionals to handle that.

Now, since v1.1.0 we decided to include a separate task for that named ChatGeneration that indeed expects a column named messages that will check that's compatible with the expected format and then call the process method with that. This is not also more intuitive, but also the cost of maintaining it is low.

Additionally, this let us define the optional input system_prompt in TextGeneration, meaning that if the system_prompt is available and the use_system_prompt flag is set to True, then the system_prompt will be included as the first message before the instruction.

So on, in v1.1.0 a DeprecationWarning will be raised when using TextGeneration for ChatGeneration, encouraging the user to use ChatGeneration instead, while showing a DeprecationWarning to be applied in v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant