Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt EvolQuality and EvolInstruct to share a combined base class #458

Open
davidberenstein1957 opened this issue Mar 21, 2024 · 1 comment
Open

Adapt EvolQuality and EvolInstruct to share a combined base class #458

davidberenstein1957 opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
Both tasks seem to share a lot of logic so there is some code duplication.

Describe the solution you'd like
Consider creating a shared base class.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the enhancement New feature or request label Mar 21, 2024
@davidberenstein1957
Copy link
Member Author

As proposed here #429

@davidberenstein1957 davidberenstein1957 changed the title Combine EvolQuality and EvolInstruct in shared base Adapt EvolQuality and EvolInstruct to share a combined base class Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidberenstein1957