Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrained diff of JS collections #33508

Closed
vsvamsi1 opened this issue May 16, 2024 · 0 comments · Fixed by #33435
Closed

Constrained diff of JS collections #33508

vsvamsi1 opened this issue May 16, 2024 · 0 comments · Fixed by #33435
Assignees
@vsvamsi1
Labels
Performance Pod All things related to Appsmith performance Performance Issues related to performance Task A simple Todo

Comments

@vsvamsi1
Copy link
Contributor

Perform diff of only the affected JS collections not the entire list of JS collections and for non JS updates evaluation we should not perform a diff on any JS collection.. This should improve the p100 of each evaluation.
@vsvamsi1 vsvamsi1 added Performance Issues related to performance Performance Pod All things related to Appsmith performance labels May 16, 2024
@vsvamsi1 vsvamsi1 self-assigned this May 16, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 16, 2024
@vsvamsi1 vsvamsi1 mentioned this issue May 17, 2024
Merged
2 tasks
vsvamsi1 added a commit that referenced this issue May 27, 2024
@vsvamsi1
chore: constrain the diff on only affected JS actions (#33435)
d8f3911 
## Description
Perform diff of only the affected JS collections not the entire list of
JS collections and for non JS updates evaluation we should not perform a
diff on any JS collection.. This should improve the p100 of each
evaluation.


Fixes #33508
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9248167182>
> Commit: e178485
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9248167182&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->












































































## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsvamsi1 vsvamsi1

Labels
Performance Pod All things related to Appsmith performance Performance Issues related to performance Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: constrain the diff on only affected JS actions appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @vsvamsi1