Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Appsmith store should show lint error when reassinged or mutated #29969

Closed
1 task done
ramsaptami opened this issue Jan 2, 2024 · 1 comment · Fixed by #33484
Closed
1 task done

[Bug]: Appsmith store should show lint error when reassinged or mutated #29969

ramsaptami opened this issue Jan 2, 2024 · 1 comment · Fixed by #33484
Assignees
@sneha122
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Enhancement New feature or request FE Coders Pod Issues related to users writing javascript in appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration JS Linting & Errors Issues related to JS Linting and errors JS Usability usability issues with JS editor and JS elsewhere Production

Comments

@ramsaptami
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Store value does not change value when mutated or using push function which either needs to be handled by a lint error or enable the functionality

Steps To Reproduce

https://theappsmith.slack.com/archives/C0341RERY4R/p1704169992778679?thread_ts=1703873472.896449&cid=C0341RERY4R

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud
@ramsaptami ramsaptami added Bug Something isn't working Production Needs Triaging Needs attention from maintainers to triage JS Linting & Errors Issues related to JS Linting and errors JS Usability usability issues with JS editor and JS elsewhere labels Jan 2, 2024
@github-actions github-actions bot added the FE Coders Pod Issues related to users writing javascript in appsmith label Jan 2, 2024
@ramsaptami ramsaptami changed the title [Bug]: Store value does not change value when mutated or using push function [Bug]: Appsmith store does not change value when mutated or when using push function Jan 2, 2024
@satbir121 satbir121 added Enhancement New feature or request and removed Bug Something isn't working labels Jan 2, 2024
@satbir121 satbir121 changed the title [Bug]: Appsmith store does not change value when mutated or when using push function [Feature]: Appsmith store should change value when mutated or when using push function on an array Jan 2, 2024
@rishabhrathod01
Copy link
Contributor

@ramsaptami store value would remain immutable and hence we show go-ahead to show lint error when using push or assigning the value. I will change the title of the task accordingly.

@rishabhrathod01 rishabhrathod01 changed the title [Feature]: Appsmith store should change value when mutated or when using push function on an array [Bug]: Appsmith store should show lint error when reassinged or mutated Apr 2, 2024
@rohan-arthur rohan-arthur added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label Apr 17, 2024
@github-actions github-actions bot added the Integrations Pod Issues related to a specific integration label Apr 17, 2024
@rishabhrathod01 rishabhrathod01 added the Bug Something isn't working label May 3, 2024
@rishabhrathod01 rishabhrathod01 removed their assignment May 3, 2024
@github-actions github-actions bot added the BE Coders Pod Issues related to users writing code to fetch and update data label May 3, 2024
@sneha122 sneha122 self-assigned this May 14, 2024
@sneha122 sneha122 mentioned this issue May 15, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 17, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 17, 2024
@ramsaptami ramsaptami removed QA Needs QA attention Needs Triaging Needs attention from maintainers to triage labels Jun 6, 2024
@github-actions github-actions bot removed the QA Pod Issues under the QA Pod label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sneha122 sneha122

Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Enhancement New feature or request FE Coders Pod Issues related to users writing javascript in appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration JS Linting & Errors Issues related to JS Linting and errors JS Usability usability issues with JS editor and JS elsewhere Production
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Added lint error for appsmith store mutations appsmithorg/appsmith
7 participants
@bharath31 @rishabhrathod01 @sneha122 @satbir121 @appsmith-bot @ramsaptami @rohan-arthur