Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Adjust onPageLoad logic w.r.t. module instances used inside modules #33466

Open
subrata71 opened this issue May 15, 2024 · 4 comments
Open
Assignees
Labels
Backend This marks the issue or pull request to reference server code Module consumer Issues related to the module consumer side Packages pod issues that belong to the packages pod Task A simple Todo

Comments

@subrata71
Copy link
Contributor

subrata71 commented May 15, 2024

Description

Currently, when a module consumes other modules, references to those nested modules are treated as module instances. These nested module instances are hidden from direct use by the consumer but are triggered internally whenever the outermost module references them.

To ensure consistency, if the outermost module is set to run on page load, all nested module instances it references should also be marked to run on page load automatically. This adjustment is necessary to maintain the expected behavior and ensure that all dependent modules initialize correctly when the page loads.

@subrata71 subrata71 added Backend This marks the issue or pull request to reference server code Task A simple Todo Packages pod issues that belong to the packages pod Module consumer Issues related to the module consumer side labels May 15, 2024
@subrata71 subrata71 self-assigned this May 15, 2024
@Harshithazemoso
Copy link

Hello @subrata71
We picked this issue, and our finding is that modules is available in business edition,
so in current codebase we cannot fix anything about this issue.
Please confirm if our understanding is correct
@akshayvijayjain

@subrata71
Copy link
Contributor Author

Thanks, @Harshithazemoso for showing interest in solving this issue. Yes, you are correct! Modules is available in the business edition only.

@akshayvijayjain
Copy link

Thank you, @subrata71 , so basically you are saying it is not possible to work on this issue, with current open source codebase?

@subrata71
Copy link
Contributor Author

Yes, that's correct. @akshayvijayjain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Module consumer Issues related to the module consumer side Packages pod issues that belong to the packages pod Task A simple Todo
Projects
None yet
Development

No branches or pull requests

3 participants