Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming Data for the next major version? #52

Open
dimitribouniol opened this issue May 12, 2024 · 0 comments
Open

Consider renaming Data for the next major version? #52

dimitribouniol opened this issue May 12, 2024 · 0 comments

Comments

@dimitribouniol
Copy link

dimitribouniol commented May 12, 2024

First of all, thanks for making this available as a kicking off point for interacting with the App Store server APIs. I was genuinely excited to start using it!

Unfortunately, within seconds of adding this library to my Vapor project, I was immediately met with some new errors: 'Data' is ambiguous for type lookup in this context:

image

This is unfortunate, as lots of code that uses this will likely be working with Foundation as well, if only for their Codable Request/Response types, leading to the very silly spelling of Foundation.Data (which most would probably wonder why it was even necessary). Could we consider renaming it to AppMetadata or keep it under an AppStore namespace (ie. AppStore.Data)?

Similarly, but less egregious, was a conflict with Vapor's Environment, another package that has an extreme likelihood of being used with this one given its popularity for server-based swift implementations.

This isn't blocking in anyway given I could rename the conflicts with the module name prefix, but it certainly added some friction to the process of getting started, so hoping we could decrease that wherever possible 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant