Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support update topic reserved time for topic in tiered storage #8129

Closed
1 task done
yuz10 opened this issue May 13, 2024 · 1 comment · Fixed by #8130
Closed
1 task done

[Enhancement] support update topic reserved time for topic in tiered storage #8129

yuz10 opened this issue May 13, 2024 · 1 comment · Fixed by #8130

Comments

@yuz10
Copy link
Member

yuz10 commented May 13, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

support update topic reserved time for topic in tiered storage

Motivation

Currently the message reserved period can only be set for the broker as a whole and cannot be set for topics individually. In advantage of tiered storage, it is able to set reserved period for topics individually.

Describe the Solution You'd Like

add reserved time config to topic metadata in tiered storage, and delete the file in tiered storage in time.

Describe Alternatives You've Considered

add reserved time config to topics.json in broker topicConfigManager

Additional Context

No response

@lizhimins
Copy link
Member

lizhimins commented May 14, 2024

How about marking TTL at the topic level in the attributes of TopicConfig?
Please refer to 'org.apache.rocketmq.common.attribute.Attribute' and 'org.apache.rocketmq.common.TopicAttributes'

lizhimins pushed a commit that referenced this issue May 22, 2024
Co-authored-by: yuzhou <yuzhou4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants