Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8123] Support bitmap filter for Static Subscription #8125

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8123] Support bitmap filter for Static Subscription #8125

wants to merge 9 commits into from

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented May 13, 2024

Which Issue(s) This PR Fixes

Fixes #8123

Brief Description

Support bitmap filter for Static Subscription

How Did You Test This Change?

Integration test

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (159a603) to head (c9fc716).
Report is 4 commits behind head on develop.

Files Patch % Lines
...a/org/apache/rocketmq/broker/BrokerController.java 0.00% 10 Missing and 1 partial ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 10.00% 8 Missing and 1 partial ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 0.00% 3 Missing ⚠️
...roker/client/DefaultConsumerIdsChangeListener.java 66.66% 0 Missing and 2 partials ⚠️
...ocketmq/broker/processor/PullMessageProcessor.java 0.00% 2 Missing ⚠️
.../rocketmq/broker/filter/ConsumerFilterManager.java 66.66% 0 Missing and 1 partial ⚠️
...rocketmq/broker/metrics/ConsumerLagCalculator.java 0.00% 1 Missing ⚠️
...e/rocketmq/remoting/protocol/filter/FilterAPI.java 0.00% 0 Missing and 1 partial ⚠️
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8125      +/-   ##
=============================================
- Coverage      42.94%   42.86%   -0.09%     
+ Complexity     10387    10368      -19     
=============================================
  Files           1270     1270              
  Lines          88694    88720      +26     
  Branches       11401    11411      +10     
=============================================
- Hits           38092    38030      -62     
- Misses         45914    45988      +74     
- Partials        4688     4702      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins
Copy link
Member

如果 pull 请求带的过滤表达式和 register 的不一致行为是什么？

@drpmma
Copy link
Contributor Author

drpmma commented May 16, 2024 •
edited

The filter with pull requests will take effect when get messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support bitmap filter for Static Subscription
3 participants
@drpmma @codecov-commenter @lizhimins