Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Paimon Spark Extensions conflict with Iceberg #3212

Open
1 of 2 tasks
wForget opened this issue Apr 15, 2024 · 0 comments
Open
1 of 2 tasks

[Feature] Paimon Spark Extensions conflict with Iceberg #3212

wForget opened this issue Apr 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@wForget
Copy link
Member

wForget commented Apr 15, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

The Call syntax is defined in both Iceberg and Paimon, which may cause conflicts when I introduce their SparkSessionExtensions at the same time.

Reproduce:

spark.sql.extensions=org.apache.paimon.spark.extensions.PaimonSparkSessionExtensions,org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions

-- create iceberg table
CREATE TABLE iceberg_catalog.sample.iceberg_t1 (
    user_id BIGINT,
    item_id BIGINT,
    behavior STRING,
    dt STRING,
    hh STRING
) using iceberg;

-- create paimon table
CREATE TABLE paimon_catalog.sample.paimon_t1 (
    user_id BIGINT,
    item_id BIGINT,
    behavior STRING,
    dt STRING,
    hh STRING
) TBLPROPERTIES (
    'primary-key' = 'dt,hh,user_id'
);

-- Successed
CALL iceberg_catalog.system.remove_orphan_files(table => "sample.iceberg_t1");

-- Failed, use iceberg ResolveProcedures
CALL paimon_catalog.sys.remove_orphan_files(table => "sample.paimon_t1");

duplicate: apache/iceberg#10143

Solution

If currentCatalog is not Spark Session catalog and Paimon Spark Catalog, we first use delegate parser to parse sqlText in PaimonSparkSqlExtensionsParser#parsePlan.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant