Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: JmsIOTests don't actually verify that the queue is empty #31332

Closed
2 of 16 tasks
tilgalas opened this issue May 17, 2024 · 1 comment · Fixed by #31334
Closed
2 of 16 tasks

[Bug]: JmsIOTests don't actually verify that the queue is empty #31332

tilgalas opened this issue May 17, 2024 · 1 comment · Fixed by #31334
Assignees

Comments

@tilgalas
Copy link
Contributor

tilgalas commented May 17, 2024

What happened?

In some of the tests in the JmsIOTest class (eg. https://github.com/apache/beam/blob/v2.56.0/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java#L235) there's a code that presumably asserts that the queue is empty after the test pipeline finishes its run. I believe the code there is missing a connection.start() call before calling the consumer.receiveNoWait() and thus will never see any outstanding messages in the queue. In other words, the assertNull(msg) that follows cannot ever fail.

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@tilgalas
Copy link
Contributor Author

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant