Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark public parameters show up on the vampir dump #10

Open
mariari opened this issue Apr 19, 2022 · 0 comments
Open

Mark public parameters show up on the vampir dump #10

mariari opened this issue Apr 19, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mariari
Copy link
Member

mariari commented Apr 19, 2022

Currently I ignore public private parameters. However with little work we can get public parameters to functions to emit when we dump the entry point to the circuit.

Care has to be taken care not to have any other functions public parameters be marked as public when we compile down the circuit however.

We can either chose to inject this in the primitive-circuit phase of the compiler

;; src/pass/pass.lisp
(-> primtitve-circuit (spc:fully-expanded-list spc:circuit) spc:prim-circuit)
(defun primtitve-circuit (terms circuit)
  (~>> (spc:make-prim-circuit :name (spc:name circuit) :body terms)
       (fill-in-arguments circuit)
       (fill-in-output    circuit)))

or rather as special behavior for the main function to compile.

@mariari mariari added the good first issue Good for newcomers label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant