Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dto types validation #8496

Merged
merged 8 commits into from
May 15, 2024
Merged

Feat/dto types validation #8496

merged 8 commits into from
May 15, 2024

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented May 14, 2024

Close: #8493 #8494 #8495

PR Details

  • Validate the type definition for custom actions and DTOs
  • prevent creation of types with invalid DtoID
  • prevent usage of unsupported types (undefined, null for DTOs, and also JSON for actions)
  • update the function definition for jovu - remove JSON from createAction

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented May 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3cce5df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mulygottlieb mulygottlieb merged commit 60320a7 into next May 15, 2024
11 checks passed
@mulygottlieb mulygottlieb deleted the feat/dto-types-validation branch May 15, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants